Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImportListExclusionController | API call made to deprecated endpoint #128

Open
jamcalli opened this issue Apr 9, 2024 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@jamcalli
Copy link

jamcalli commented Apr 9, 2024

Watchlistarr is causing Sonarr to spit out the following warning logs. Probably not a big deal, but just something I noticed.

ImportListExclusionController | API call made to deprecated endpoint from http4s-ember/0.23.23

Great project!

@nylonee
Copy link
Owner

nylonee commented Apr 11, 2024

Oohh this is good spotting!

You are right, in the Sonarr API docs the standard ImportListExclusion call has been deprecated
Screenshot 2024-04-11 090311

It looks like we now are expected to use the paginated version.

However since we use the same API call for all Sonarr calls, I'm confused as to whether this applies to Sonarr v3 and v4, or only v4 (or only v3?!) I'll have to do some more investigation and determine what's the best non-breaking way of implementing this change

@nylonee
Copy link
Owner

nylonee commented Apr 11, 2024

Looks like this is the PR that introduced the changes, I think that's only Sonarr v4

The best thing to do at the moment is to not do anything, as this will make the Watchlistarr client deviate, and we'll need to keep track of which version of Sonarr the user is using.

In the future we can explore doing this (or having fallback API calls), but it's probably low-ish priority at the moment :)

@nylonee nylonee added enhancement New feature or request good first issue Good for newcomers and removed good first issue Good for newcomers labels Apr 11, 2024
@AhmedNSidd
Copy link

+1 for this issue. It's becoming a hassle to read my Sonarr logs because of the pollution. I tried to work on this over the weekend but don't have enough competency over Scala or codebase to be able to do it.

@stormshaker
Copy link

Note this same warning is being logged in the Radarr logs too:

API call made to deprecated endpoint from watchlistarr/1.0

@albinmedoc
Copy link

This should be fixed as soon as possible.
This causes several unnecessary IO operations every minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants