Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass bypass function to mixnet client #1736

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Pass bypass function to mixnet client #1736

merged 4 commits into from
Dec 9, 2024

Conversation

neacsu
Copy link
Collaborator

@neacsu neacsu commented Dec 6, 2024

This change is Reviewable

Copy link
Contributor

@pronebird pronebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 9 files at r1.
Reviewable status: 1 of 9 files reviewed, 1 unresolved discussion (waiting on @neacsu, @octol, @rokas-ambrazevicius, and @zaneschepke)


nym-vpn-core/crates/nym-authenticator-client/src/lib.rs line 3 at r1 (raw file):

use std::{
    net::{Ipv4Addr, Ipv6Addr},
    os::fd::RawFd,

Won't build on windows AFAIK

Copy link
Collaborator Author

@neacsu neacsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @octol, @pronebird, @rokas-ambrazevicius, and @zaneschepke)


nym-vpn-core/crates/nym-authenticator-client/src/lib.rs line 3 at r1 (raw file):

Previously, pronebird (Andrej Mihajlov) wrote…

Won't build on windows AFAIK

Fixed it with a bunch of guards for android

@neacsu neacsu requested a review from pronebird December 6, 2024 14:17
Copy link
Contributor

@pronebird pronebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 9 files at r1, 8 of 8 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @octol, @rokas-ambrazevicius, and @zaneschepke)

@neacsu neacsu merged commit b3ec6cd into develop Dec 9, 2024
8 of 11 checks passed
@neacsu neacsu deleted the feature/bypass2 branch December 9, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants