Isolate call to Network::fetch() outside of runtime to prevent panic #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panic says: Cannot drop a runtime in a context where blocking is not allowed. This happens when a runtime is dropped from within an asynchronous context.
octol
approved these changes
Dec 10, 2024
pronebird
added a commit
that referenced
this pull request
Dec 10, 2024
…1767) Panic says: Cannot drop a runtime in a context where blocking is not allowed. This happens when a runtime is dropped from within an asynchronous context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following panic has been thrown each time the windows service started:
I figured that a call to
Network::fetch()callstokio::runtime::block_on()while the outer scope of the service is already running within a runtime. This PR simply moves the blocking call outside of our runtime.Ideally we should find a way to make this call async and move it after reporting the
StartPendingstatus to the service control manager (SCM) perhaps giving it a time hint to prevent it from killing the service too soon.But as a temporary solution this should probably work.
This change is