Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels of inputs not readable #88

Open
eddy147 opened this issue Apr 2, 2024 · 3 comments
Open

Labels of inputs not readable #88

eddy147 opened this issue Apr 2, 2024 · 3 comments

Comments

@eddy147
Copy link

eddy147 commented Apr 2, 2024

the pop-up inputs do not show text, so it's impossible to input text.

I can batter show a picture.
With tokyo-night, when adding/renaming a file in NeoTree:

image

In oxocarbon:

image

To reproduce:

  • install LazyVim
  • install oxocarbon plugin
@mCassy
Copy link

mCassy commented Sep 1, 2024

@eddy147 hey, you might want to set FloatBorder and FloatTitle to something like:

vim.api.nvim_set_hl(0, "FloatTitle", { fg = oxocarbon.base04, bg = oxocarbon.none })
vim.api.nvim_set_hl(0, "FloatBorder", { fg = oxocarbon.base02, bg = oxocarbon.base02 })

to fix neo-tree popups
image

@kev-chien
Copy link

I ran into this problem as well, and am also using LazyVim - just specifying that this is a bit specific to using the neo-tree plugin so isn't strictly tied to LazyVim.

As @mCassy pointed out, this appears to be fixable by adjusting the FloatTitle and FloatBorder.

The neo-tree highlights code constructs the NeoTreeTitleBar highlight group using the Normal background as the foreground, and the FloatBorder foreground as the background.

The issue is that by default, it ends up with this (inspecting via :highlights):

NeoTreeTitleBarxxx guifg=#161616 guibg=#131313

Where the fg and bg are too close in color to be viewable in NeoTree.

It's because it derives from Normal and FloatBorder:

FloatBorderxxx guifg=#131313 guibg=#131313
...
Normalxxx guifg=#d0d0d0 guibg=#161616

My fix for this is to create my own fork to directly modify the FloatBorder highlight, so it has a brighter fg. See commit

Which ends up giving the following output, with the default neo-tree popup_border_style:
Screenshot 2024-11-10 at 11 18 27 PM

I prefer setting popup_border_style to the rounded style:
Screenshot 2024-11-10 at 11 17 13 PM

@kev-chien
Copy link

It may also be worth calling out that if you don't change the colors and just directly switch the neo-tree popup_border_style to rounded (or perhaps other styles), it'll make the title text visible, you just don't see the borders.

Screenshot 2024-11-10 at 11 50 31 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants