Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readonly option #6

Closed
bertspaan opened this issue Dec 14, 2016 · 5 comments
Closed

Add readonly option #6

bertspaan opened this issue Dec 14, 2016 · 5 comments
Assignees

Comments

@bertspaan
Copy link
Collaborator

No description provided.

@bertspaan
Copy link
Collaborator Author

@bertspaan bertspaan self-assigned this Dec 20, 2016
@bertspaan
Copy link
Collaborator Author

First, do #5.

@bertspaan
Copy link
Collaborator Author

bertspaan commented Dec 20, 2016

@mmmenno: let me know when you need this.

@mmmenno
Copy link

mmmenno commented Dec 21, 2016

We don't need this until the first project has been crowdsourced (in 2-3 months, i guess).

It would be nice, however, to know beforehand what parameters the readonly version expects: the fieldOfView geojson? Or cameraPoint, targetPoint and angle?

We've been thinking about what to save in our Leiden project, and came up with:

  • fieldOfView geojson
  • targetPoint (for practical use, projectowners don't have to calculate it from linestring themselves)
  • cameraPoint (same, in the geojson of course, but a bit obscure)

What do you save for NYPL projects?

@bertspaan
Copy link
Collaborator Author

The initialization function of the camera module will accept the following GeoJSON features: https://github.com/nypl-spacetime/field-of-view#api. In addition, I will add that fromFeature also accepts its own output (so you can feed an output field-of-view GeometryCollection back into fromFeature).

And I will add options to the getFieldOfView function, so you can specify which kind of field-of-view feature you want returned: one point, two points, GeometryCollection. All of those features will include angle, bearing and distance properties, so you can convert between them.

I am storing the GeometryCollection with one Point (camera position) and one two-point LineString (field-of-view line).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants