Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interdependency between this and monorepo #51

Open
L-as opened this issue Jun 21, 2023 · 5 comments
Open

Interdependency between this and monorepo #51

L-as opened this issue Jun 21, 2023 · 5 comments

Comments

@L-as
Copy link
Contributor

L-as commented Jun 21, 2023

MinaProtocol/mina depends on this, but this also depends on the monorepo.
Very little is gained from this setup AFAICT compared to having it be part of the monorepo properly rather than as a submodule.
Alternatively you could break the cycle and remove the submodule from the monorepo.

@L-as
Copy link
Contributor Author

L-as commented Jun 22, 2023

I guess the point is that SnarkyJS can have this as a submodule and not the whole Mina repo, but is the code here really used? I assume it's essentially only the compiled result that is used, which shouldn't be part of this repo anyway.

@mitschabaude
Copy link
Collaborator

mitschabaude commented Jun 22, 2023

Hey @L-as, this repo has a lot of TS code that's used in snarkyjs.

Regarding the Rust/OCaml deps in here, as you said it greatly speeds up snarkyjs development to not have to change the Mina repo / be tied to a Mina branch every time you change snarkyjs. The entangling of Mina and snarkyjs development was very bad for velocity. The future direction for this repo will likely be to move more stuff (like snarky-ml, pickles etc) into direct dependencies of snarkjys, instead of being an "inverted" dependency via the Mina repo, so that snarkyjs can be developed largely independently of Mina

@mitschabaude
Copy link
Collaborator

The compiled result has to be part of the repo to enable developers to work on snarkyjs without having to build everything from source

@L-as
Copy link
Contributor Author

L-as commented Jun 22, 2023

Yes but that compiled result could be part of the snarkyjs repo.

@mitschabaude
Copy link
Collaborator

Yes but that compiled result could be part of the snarkyjs repo.

That's true :D I guess it felt natural to put it next to the source code. Usually a change of the compiled artifacts will correspond to a change of the source code, so you get both of those changes in the same PR instead of split between repos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants