Add support to pad skinned mesh buffers for the Skinning sample #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple in order to make it compliant for Metal back end Signed-off-by: moudgils <[email protected]>
Signed-off-by: moudgils <[email protected]>
|
The pull request was tested by QA on the branch o3de-atom-sampleviewer/moudgils/PadSkinningStreamBuffers:
Two issues have been reported:
Please note that due to time constraints it was not possible to confirm whether the issues also occur on the ASV Development branch. This will be verified tomorrow. |
…eviewer into moudgils/PadSkinningStreamBuffers Signed-off-by: moudgils <[email protected]>
Signed-off-by: moudgils <[email protected]>
VickyAtAZ
approved these changes
Aug 22, 2023
mbalfour-amzn
approved these changes
Aug 29, 2023
Signed-off-by: moudgils <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buffers related to procedural meshes used for the skinning pass were padded in order to respect RPI::SkinnedMeshBufferAlignment. This helps ensure we are able to respect alignment restrictions across all backends. Tested on PC, Mac and ios
Related core engine PR - o3de/o3de#16566
