From 55913057fe5ab0a2bdef36ee2ccbdbe05f8fc64a Mon Sep 17 00:00:00 2001 From: Zach Trocinski Date: Tue, 30 Jul 2024 11:22:04 -0500 Subject: [PATCH] Fix issues with version.json and extra env declaration --- avm/res/app/container-app/README.md | 15 +++++++++------ .../container-app/tests/e2e/max/main.test.bicep | 6 ------ avm/res/app/container-app/version.json | 2 +- 3 files changed, 10 insertions(+), 13 deletions(-) diff --git a/avm/res/app/container-app/README.md b/avm/res/app/container-app/README.md index e330a7f7e3..5a13e660bd 100644 --- a/avm/res/app/container-app/README.md +++ b/avm/res/app/container-app/README.md @@ -29,7 +29,7 @@ The following section provides usage examples for the module, which were used to - [Using only defaults](#example-1-using-only-defaults) - [Without ingress enabled](#example-2-without-ingress-enabled) -- [Max](#example-3-max) +- [Using large parameter set](#example-3-using-large-parameter-set) - [VNet integrated container app deployment](#example-4-vnet-integrated-container-app-deployment) - [WAF-aligned](#example-5-waf-aligned) @@ -185,7 +185,10 @@ module containerApp 'br/public:avm/res/app/container-app:' = {

-### Example 3: _Max_ +### Example 3: _Using large parameter set_ + +This instance deploys the module with most of its features enabled. +

@@ -200,8 +203,8 @@ module containerApp 'br/public:avm/res/app/container-app:' = { { env: [ { - name: 'test' - value: 'max' + name: 'TestGuid' + secretRef: 'customtest' } ] image: 'mcr.microsoft.com/azuredocs/containerapps-helloworld:latest' @@ -293,8 +296,8 @@ module containerApp 'br/public:avm/res/app/container-app:' = { { "env": [ { - "name": "test", - "value": "max" + "name": "TestGuid", + "secretRef": "customtest" } ], "image": "mcr.microsoft.com/azuredocs/containerapps-helloworld:latest", diff --git a/avm/res/app/container-app/tests/e2e/max/main.test.bicep b/avm/res/app/container-app/tests/e2e/max/main.test.bicep index 67faf0ba5c..f2d4a11f52 100644 --- a/avm/res/app/container-app/tests/e2e/max/main.test.bicep +++ b/avm/res/app/container-app/tests/e2e/max/main.test.bicep @@ -131,12 +131,6 @@ module testDeployment '../../../main.bicep' = [ periodSeconds: 3 } ] - env: [ - { - name: 'test' - value: 'max' - } - ] } ] } diff --git a/avm/res/app/container-app/version.json b/avm/res/app/container-app/version.json index 7b2a016ddc..a89e5c9d3c 100644 --- a/avm/res/app/container-app/version.json +++ b/avm/res/app/container-app/version.json @@ -1,6 +1,6 @@ { "$schema": "https://aka.ms/bicep-registry-module-version-file-schema#", - "version": "v0.7-1", + "version": "0.7", "pathFilters": [ "./main.json" ]