Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon paths resolving in merged configs #213

Open
viktor-yakubiv opened this issue Jul 13, 2020 · 2 comments
Open

Fix icon paths resolving in merged configs #213

viktor-yakubiv opened this issue Jul 13, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@viktor-yakubiv
Copy link
Member

I am not sure it's handled correctly. Let's imagine, we have icons in 2 packages or 2 different directories. We want to resolve one list from the first directory and another one from the second directory. Is it handled like that before merging config objects?

Comes after #206 (comment)

@viktor-yakubiv viktor-yakubiv added the bug Something isn't working label Jul 13, 2020
@Joozty
Copy link
Member

Joozty commented Jul 13, 2020

To add on top of it: f we want to having it we need to add support for array in icons field something like:

  icons: [
    {
        path: '/package1Root',
        files: ['icon.svg'],
    },
    {
        path: 'package2Root',
        files: [icon.svg],
    },
]

@viktor-yakubiv
Copy link
Member Author

We could but I would rather opt-out of this. If the user wants to have icons from various directories, he/she should expand absolute paths manually. So, I would keep supporting only object: { files: array[string], path: string } or array[string]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants