This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
make resource required and also fix examples to be consistent with spec #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonderflow
changed the title
fibonacci1729
approved these changes
Oct 30, 2019
|
I still think this is a bad idea to have something outside of the orchestrator be the thing that decides on defaults. We have already seen this backfire in practice. |
|
@technosophos what if remove the default ? we make it real required in spec? |
|
@technosophos , thoughts after @wonderflow's comment? |
|
My thoughts on this: oam-dev/spec#218 (comment), in short:
|
|
So what do you think about this PR now? @technosophos |
technosophos
approved these changes
Nov 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
though discussion is still undergoing（oam-dev/spec#218） , we could align resource requirement with OAM spec v1.0.0-alpha.1, so we won't make confusion or misleading。 fixes #406 fixes #364