Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on required 'resources' attribute #302

Open
clareliguori opened this issue Jan 17, 2020 · 2 comments
Open

Question on required 'resources' attribute #302

clareliguori opened this issue Jan 17, 2020 · 2 comments

Comments

@clareliguori
Copy link

I noticed that the container resources attribute is marked as required in the spec. Is it intended to be required?
https://github.com/oam-dev/spec/blob/master/3.component_model.md#container

But none of the component schematic examples in this repo have resources configuration:
https://github.com/oam-dev/samples

Similarly there are examples in the Rudr repo without resources config, and the implementation has default values for CPU and memory requirements.
https://github.com/oam-dev/rudr/blob/master/examples/voting/components.yaml
https://github.com/oam-dev/rudr/blob/master/src/schematic/component.rs#L567-L579

@hongchaodeng
Copy link
Member

Ref #58, #182, and oam-dev/rudr#435.

We sort of ended up with different opinions. Time to revisit it.

@vturecek
Copy link
Member

We still have an open PR for this: #218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants