Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oban.Pro.Testing.run_workflow/2 drain jobs not related to workflow #1205

Open
thiagopromano opened this issue Dec 18, 2024 · 1 comment
Open
Labels
area:pro Related to Oban Pro kind:bug Something isn't working

Comments

@thiagopromano
Copy link

thiagopromano commented Dec 18, 2024

Environment

  • Oban Version: 1.5.0-rc.6

Current Behavior

On our test suite, I've noticed that Oban.Pro.Testing.run_workflow/2 runs jobs that are scheduled during the workflow execution but don't belong to the workflow.

I would expect that run_workflow/2 would run only the jobs that share the workflow_id, not drain all the scheduled jobs. If that is intended, I suggest adding a note to the function documentation.

@thiagopromano thiagopromano changed the title Oban.Pro.Testing.run_worflow/2 drain jobs not related to workflow Oban.Pro.Testing.run_workflow/2 drain jobs not related to workflow Dec 18, 2024
@sorentwo sorentwo added kind:bug Something isn't working area:pro Related to Oban Pro labels Dec 18, 2024
@sorentwo
Copy link
Member

I would expect that run_workflow/2 would run only the jobs that share the workflow_id, not drain all the scheduled jobs. If that is intended, I suggest adding a note to the function documentation.

That's a perfectly normal expectation and the quirk bites people every once in a while. Working on a fix rather than a caveat in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:pro Related to Oban Pro kind:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants