Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into caching traits' "sealed" status to improve performance #373

Open
obi1kenobi opened this issue Aug 18, 2024 · 0 comments
Open

Look into caching traits' "sealed" status to improve performance #373

obi1kenobi opened this issue Aug 18, 2024 · 0 comments

Comments

@obi1kenobi
Copy link
Owner

Determining whether a trait is sealed requires determining whether any of its supertraits in the same crate are sealed. If checking traits' sealed status is slow, we may be able to cache those lookups.

Doing this while keeping the adapter and IndexedCrate types Send + Sync may be a bit of a challenge. Parallel hashmaps tend to introduce drop glue, which causes lifetime problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant