Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning doesn't match ChEBI #2

Open
cthoyt opened this issue Sep 3, 2022 · 6 comments · May be fixed by #5
Open

Versioning doesn't match ChEBI #2

cthoyt opened this issue Sep 3, 2022 · 6 comments · May be fixed by #5

Comments

@cthoyt
Copy link

cthoyt commented Sep 3, 2022

I think it would be valuable to have this match the versioning of ChEBI (which is using sequential version numbers) instead of introducing an arbitrary date versioning system

@matentzn
Copy link
Contributor

matentzn commented Sep 3, 2022

This is going to put a bit of a burden on the maintainers, but you are probably right.

@cthoyt
Copy link
Author

cthoyt commented Sep 3, 2022

Based on a similar question today https://obo-communitygroup.slack.com/archives/C01BTR3E8CU/p1662209700361059?thread_ts=1662209122.517419&cid=C01BTR3E8CU it looks like having a reusable tool that can get the version out of an arbitrary ontology IRI would be nice

@matentzn
Copy link
Contributor

matentzn commented Sep 3, 2022

A two step process is to convert the ontology to json, then us jq. You can never be really sure what serialisation the ontology is stored in otherwise. Or just use sparql?

@cthoyt
Copy link
Author

cthoyt commented Sep 3, 2022

Sounds good enough for this

Some notes:

robot convert -I http://purl.obolibrary.org/obo/chebi.owl -o chebi.json
cat chebi.json | jq ".graphs[0].meta.basicPropertyValues

matentzn added a commit that referenced this issue Sep 3, 2022
@matentzn matentzn linked a pull request Sep 3, 2022 that will close this issue
@cmungall
Copy link
Member

I can foresee a frequent need to get a new slim in between CHEBI releases. I'm assuming we in fact want to automate this repo and push releases after PRs on the txt file.

This would necessitate either making the slim versions patch releases on the chebi major/minor system, which doesn't sit so well. Or treating the slim as a separate obo product and maintaining a triple that points back to the source chebi release.

@matentzn
Copy link
Contributor

We will go for the latter, documenting the CHEBI version a slim was sourced from I think. I need to make frequent re releases, sometimes more than one per week.

It's a pity that GH actions can't handle CHEBI at all.I would feel better with a SLME module over a graph module but if we obtain for a more OBO-esque upper level anyways, we can explore options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants