Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Chronicle exporter #1331

Merged
merged 14 commits into from
Nov 14, 2023
Merged

Conversation

Mrod1598
Copy link

@Mrod1598 Mrod1598 commented Nov 9, 2023

Proposed Change

  • Add Chronicle exporter
Checklist
  • Changes are tested
  • CI has passed

@Mrod1598 Mrod1598 added the do not merge Don't merge this PR yet label Nov 9, 2023
@Mrod1598 Mrod1598 force-pushed the feat/chronicle-exporter branch from d811217 to 0820510 Compare November 9, 2023 13:15
exporter/chronicleexporter/config.go Show resolved Hide resolved
factories/exporters.go Outdated Show resolved Hide resolved
@Mrod1598 Mrod1598 force-pushed the feat/chronicle-exporter branch from dfb970e to cade4fa Compare November 13, 2023 15:30
}, nil
}

func buildEndpoint(cfg *Config) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some comments on this to indicate how this works or point to docs? It sounds like it wasn't easy to track down this answer so we should document what we know.

@Mrod1598 Mrod1598 requested a review from cpheps November 13, 2023 22:01
exporter/chronicleexporter/config.go Show resolved Hide resolved
exporter/chronicleexporter/config.go Outdated Show resolved Hide resolved
exporter/chronicleexporter/exporter.go Outdated Show resolved Hide resolved
exporter/chronicleexporter/factory.go Outdated Show resolved Hide resolved
exporter/chronicleexporter/factory.go Outdated Show resolved Hide resolved
exporter/chronicleexporter/marshal.go Outdated Show resolved Hide resolved
exporter/chronicleexporter/marshal.go Outdated Show resolved Hide resolved
exporter/chronicleexporter/factory.go Outdated Show resolved Hide resolved
exporter/chronicleexporter/doc.go Outdated Show resolved Hide resolved
@Mrod1598 Mrod1598 marked this pull request as ready for review November 14, 2023 15:35
@Mrod1598 Mrod1598 force-pushed the feat/chronicle-exporter branch from d4e280a to b3e5ce1 Compare November 14, 2023 15:35
@Mrod1598 Mrod1598 requested a review from a team as a code owner November 14, 2023 15:35
@Mrod1598 Mrod1598 removed the do not merge Don't merge this PR yet label Nov 14, 2023
exporter/chronicleexporter/marshal.go Outdated Show resolved Hide resolved
exporter/chronicleexporter/marshal.go Outdated Show resolved Hide resolved
exporter/chronicleexporter/config.go Show resolved Hide resolved
@Mrod1598 Mrod1598 merged commit 5482ff4 into release/v1.39.0 Nov 14, 2023
14 checks passed
@Mrod1598 Mrod1598 deleted the feat/chronicle-exporter branch November 14, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants