-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Chronicle exporter #1331
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrod1598
force-pushed
the
feat/chronicle-exporter
branch
from
November 9, 2023 13:15
d811217
to
0820510
Compare
cpheps
reviewed
Nov 9, 2023
cpheps
reviewed
Nov 13, 2023
Mrod1598
force-pushed
the
feat/chronicle-exporter
branch
from
November 13, 2023 15:30
dfb970e
to
cade4fa
Compare
cpheps
reviewed
Nov 13, 2023
}, nil | ||
} | ||
|
||
func buildEndpoint(cfg *Config) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some comments on this to indicate how this works or point to docs? It sounds like it wasn't easy to track down this answer so we should document what we know.
Mrod1598
force-pushed
the
feat/chronicle-exporter
branch
from
November 14, 2023 15:35
d4e280a
to
b3e5ce1
Compare
cpheps
approved these changes
Nov 14, 2023
BinaryFissionGames
suggested changes
Nov 14, 2023
BinaryFissionGames
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Checklist