Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): Name of binary for make kill #1973

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(dev): Name of binary for make kill #1973

merged 1 commit into from
Nov 19, 2024

Conversation

antonblock
Copy link
Contributor

@antonblock antonblock commented Nov 18, 2024 •
edited
Loading

Proposed Change

Update name of default collector binary for make kill

$ make kill
pkill -9 opampsupervisor || true
pkill -9 collector_darwin_arm64 || true
Checklist
  • Changes are tested
  • CI has passed

@antonblock antonblock requested review from dpaasman00 and a team as code owners November 18, 2024 18:31
@antonblock antonblock merged commit 44e87b9 into release/v2.0.0 Nov 19, 2024
15 checks passed
@antonblock antonblock deleted the fix/makefile-kill-target branch November 19, 2024 14:07
dpaasman00 pushed a commit that referenced this pull request Dec 9, 2024
@antonblock @dpaasman00
fix(dev): Name of binary for make kill (#1973)
ba3c7ca 
Update binary name for make kill
dpaasman00 pushed a commit that referenced this pull request Dec 16, 2024
@antonblock @dpaasman00
fix(dev): Name of binary for make kill (#1973)
3bed0aa 
Update binary name for make kill
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpaasman00 dpaasman00 dpaasman00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonblock @dpaasman00