-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use go 1.21 #767
Merged
Use go 1.21 #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #767 +/- ##
=======================================
Coverage ? 74.94%
=======================================
Files ? 133
Lines ? 10087
Branches ? 0
=======================================
Hits ? 7559
Misses ? 2056
Partials ? 472 ☔ View full report in Codecov by Sentry. |
jsirianni
added
dependencies
Pull requests that update a dependency file
security
labels
Dec 18, 2023
3 tasks
…e from the k8s api
tests that specifically run on windows This reverts commit a9ac344.
cpheps
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
We should be on the latest Go version to ensure we are receiving security fixes for the standard lib.
Switching to Go required that we update some dependencies
* K8s cluster name was removed from the SDK / Client packages for Kubernetes. I would be surprised if it was working before, because k8s does not have the concept of cluster name internally.
Please check that the PR fulfills these requirements