Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go 1.21 #767

Merged
merged 15 commits into from
Dec 18, 2023
Merged

Use go 1.21 #767

merged 15 commits into from
Dec 18, 2023

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Dec 18, 2023

Description of Changes

We should be on the latest Go version to ensure we are receiving security fixes for the standard lib.

Switching to Go required that we update some dependencies

  • Lichen license scanner
  • Zap logger and it's dependencies
  • k8s dependencies
    • Removed ClusterName logic*
  • Run windows tests without cgo, they were failing for an unknown reason. The binary we ship is cross compiled.

* K8s cluster name was removed from the SDK / Client packages for Kubernetes. I would be surprised if it was working before, because k8s does not have the concept of cluster name internally.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CI passes

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@c034064). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #767   +/-   ##
=======================================
  Coverage        ?   74.94%           
=======================================
  Files           ?      133           
  Lines           ?    10087           
  Branches        ?        0           
=======================================
  Hits            ?     7559           
  Misses          ?     2056           
  Partials        ?      472           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsirianni jsirianni added dependencies Pull requests that update a dependency file security labels Dec 18, 2023
@jsirianni jsirianni mentioned this pull request Dec 18, 2023
3 tasks
@jsirianni jsirianni requested a review from cpheps December 18, 2023 21:30
@jsirianni jsirianni merged commit aafd84f into main Dec 18, 2023
13 checks passed
@jsirianni jsirianni deleted the go-1.21 branch December 18, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants