Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to distinguish between Dock and Browser Source #455

Open
thexeos opened this issue Sep 15, 2024 · 2 comments
Open

Unable to distinguish between Dock and Browser Source #455

thexeos opened this issue Sep 15, 2024 · 2 comments

Comments

@thexeos
Copy link

thexeos commented Sep 15, 2024

Operating System Info

Windows 11

OBS Studio Version

30.2.3

Expected Behavior

It should be possible for the application interacting with JS Bindings to determine if it is running in Dock or in Browser Source.

Current Behavior

Currently, web pages loaded in both OBS Docks and Browser Sources have access to the same APIs and environment, making it difficult to differentiate between the two contexts. This creates limitations for developers who want to provide different functionality depending on whether their web page is loaded as a control panel (Dock) or as visible content (Browser Source).

Steps to Reproduce

Users commonly select a wrong type Dock vs Browser Source or load a URL that is not appropriate for the type.

For example, a webpage with interactive buttons (e.g., scene selection) might be mistakenly loaded as a Browser Source instead of a Dock. The application can't detect this, so it displays the interactive UI. Users may try to interact, but the buttons won't work, leading them to report bugs. In reality, they should have added a Dock, not a Browser Source, causing confusion and poor user experience. Similarly, a non-interactive overlay meant for the stream could be loaded as a Dock, confusing users when it doesn’t appear on the stream.

Having a reliable way to detect the obs-browser environment is the only way these issues can be caught by developers before users create support tickets.

Since there are only two possible states, there could be a boolean isDock value exposed on window.obsstudio object, or alternatively there could be a string enum { 'dock', 'browser_source' } which can be expanded later on.

@WizardCM
Copy link
Member

Hmm, good catch. I should note, however, that currently most JS bindings don't actually run/return in a dock, as they're not fully implemented there.

@thexeos
Copy link
Author

thexeos commented Sep 15, 2024

That's a good suggestion.

All the methods are present, but none of the getControlLevel, getStatus, getCurrentScene, getScenes, getTransitions, getCurrentTransition would fire when opening the page in Dock.

So that can be considered a workaround:

let isObs = false
let isObsDock = false
if (window.obsstudio) {
  isObs = true
  isObsDock = true
  window.obsstudio.getControlLevel(() => {
    isObsDock = false
  })
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants