Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not expose *raise* functions #20

Open
ghost opened this issue Nov 5, 2019 · 0 comments
Open

Do not expose *raise* functions #20

ghost opened this issue Nov 5, 2019 · 0 comments

Comments

@ghost
Copy link

ghost commented Nov 5, 2019

Using Location.raise_error has the annoying side effect that merlin can't do anything with the file. Instead, whenever we produce an error we should instead produce an [%%ocaml.error] extension point.

In ppx, we should expose no such Location.raise function to make sure new ppx rewriters do the right thing.

@ghost ghost changed the title Do expose *raise* functions Do not expose *raise* functions Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants