Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint-doc lint-fmt neglect working-directory change #760

Open
panyuewh opened this issue Feb 9, 2024 · 1 comment
Open

lint-doc lint-fmt neglect working-directory change #760

panyuewh opened this issue Feb 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@panyuewh
Copy link

panyuewh commented Feb 9, 2024

My repo has following structure and the OCaml project is located in a sub-directory

./
  binding-Julia/
  binding-OCaml/
    .ocamlformat
    dune-project
    ...
  ...

I have configure the default value for lint-fmt job in workflow.yml, following the spec https://docs.github.com/en/actions/using-jobs/setting-default-values-for-jobs. However, it seems lint-fmt@v2 neglect the change of default value of working-directory. Same for lint-doc.

jobs:
  lint-fmt:
    runs-on: ubuntu-latest
    defaults:
      run:
        working-directory: ./binding-OCaml
    steps:
@smorimoto smorimoto added the enhancement New feature or request label Jun 12, 2024
@smorimoto
Copy link
Member

The action can't even read the default working-directory. So we are planning to add an input with the exact same name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants