Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make retries and interval bigger & configurable on waitForAqua #1895

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

paulo-ocean
Copy link
Contributor

Fixes #1894

Changes proposed in this PR:

  • Make number of retries and interval configurable. increase interval default

@paulo-ocean paulo-ocean self-assigned this Dec 13, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review December 13, 2024 15:22
@mihaisc
Copy link
Contributor

mihaisc commented Dec 13, 2024

rename to waitForIndexer or something else, we don't have Aqua anymore :D

@paulo-ocean
Copy link
Contributor Author

rename to waitForIndexer or something else, we don't have Aqua anymore :D

yeah, good point, thanks 👍

Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulo-ocean paulo-ocean merged commit 9bd733b into main Jan 8, 2025
11 checks passed
@paulo-ocean paulo-ocean deleted the issue-1894-waitForAqua-interval branch January 8, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow bigger/configurable interval on waitForAqua() (when checking if a DDO is already indexed)
4 participants