Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back toast removal #52

Merged
merged 2 commits into from Jul 8, 2024
Merged

Bring back toast removal #52

merged 2 commits into from Jul 8, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jul 6, 2024

"Enforced secure chat" is now stored in the Join/Login packet. I've injected into it.
Some notes:

  • Now it requires something called "profile keys" on the client, that is. launchers MUST launch clients with "profile keys" provided. Vanilla launcher does that. Others sometimes do, sometimes don't. If they don't, the toast will be shown and there's nothing you can do about it from the server-side, but it won't break stuff.
  • Fabric injector has been moved a little bit back from TAIL, because Join packet is sent before TAIL in this method.

Properly fixes #50.

Copy link
Collaborator

@pop4959 pop4959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I was under the impression that this functionality was completely removed in the recent updates but clearly I did not look hard enough (and I have been busy lately, hence my slowness in general).

Code approved, I just ask that you make changes to the non-code portions as requested, specifically regarding the author field since this is your first PR to this project. Note that if you do plan on sticking around to help actively maintain the project, we can revisit this at a later date and I don't particularly take any issue with it then (as long as ocelotpotpie also signs off on it).

paper/src/main/resources/plugin.yml Outdated Show resolved Hide resolved
fabric/src/main/resources/fabric.mod.json Outdated Show resolved Hide resolved
paper/src/main/resources/config.yml Outdated Show resolved Hide resolved
@pop4959 pop4959 added the enhancement New feature or request label Jul 6, 2024
@ghost
Copy link
Author

ghost commented Jul 8, 2024

I've addressed your change requests @pop4959

@pop4959
Copy link
Collaborator

pop4959 commented Jul 8, 2024

LGTM, thanks

@pop4959 pop4959 merged commit a7c2360 into ocelotpotpie:main Jul 8, 2024
1 check passed
pop4959 pushed a commit that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toast notification still appearing when joining a server with enforce-secure-profiles = false
1 participant