-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #424 udev rule construction #425
fix: #424 udev rule construction #425
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: christopher-horn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @christopher-horn! It looks like this is your first PR to ocp-power-automation/ocp4-upi-powervs 🎉 |
Hi @christopher-horn. Thanks for your PR. I'm waiting for a ocp-power-automation member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@christopher-horn I assume this change is supporting dm multipath environment. Will it work on |
AFAIK all PowerVS deploys use virtual fiber channel so multi-pathing should always be enabled and in use. We use vSCSI for our on-premise PowerVC deploys and with dual VIOS again the same applies. I suppose could test and use the previous method if multi-pathing driver not enabled and active. You would rather see that? |
Agreed that PowerVS setup is always multipath.
That would be good, a simple if else can be implemented in |
@christopher-horn: PR is not mergeable. The PR state is: behind Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@christopher-horn any update? |
I still owe you update for this, my apologies as have not had time with my day to day responsibilities. I am going to close this one and open new PR when have time. |
@christopher-horn do you mind if I take up this change? We need to enable multipath as a requirement on powervs nodes. |
Yes certainly go ahead. I am sorry I have not had time. I forget if this automation sets the bootlist or not as well. I use the following on the bastion in ours though could probably be done better:
|
The above can be done much better, you really want to set the list so it round robins over the paths especially as the boot list can only hold 5 entries and in PowerVS you have 8 split into 4 and 4 since it is vFC and not vSCSI. I just realize that today. |
This seems to be a better approach for the bootlist:
|
Modifies create-disk-link.sh udev rule construction to key off the UUID as follows:
echo "ENV{DM_UUID}=="$(sudo udevadm info --root --name="$storage_device" | sudo grep DM_UUID | sudo cut -f2 -d'=')" SYMLINK+="$storage_disk_name"" | sudo tee /etc/udev/rules.d/99-custom-ocp.rules;
Resulting in a rule constructed as follows:
ENV{DM_UUID}=="mpath-360050768108002dac800000000000422" SYMLINK+="disk/pv-storage-disk"
Also moves the rule into the user rules.d directory.