Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Either Floats are valid elements or they aren't. #65

Open
gilgamec opened this issue Sep 5, 2018 · 1 comment
Open

Either Floats are valid elements or they aren't. #65

gilgamec opened this issue Sep 5, 2018 · 1 comment

Comments

@gilgamec
Copy link

gilgamec commented Sep 5, 2018

The Elt class includes Floats, while they PrintDense class works only for things over Doubles. This means that some functions, like lu, which requires only Elts, work for matrices of Floats, while e.g. qr (needing PrintDense) works only for matrices of Doubles. Some of the constructors, e.g. vr and vc, also only work with Doubles.

Could you either allow Floats as elements everywhere, or disallow them completely? Or at the very least, more cleanly delineate exactly what operations (exact solvers / iterative solvers / other stuff) they will be allowed in?

Repository owner deleted a comment from marcozocca-seal Sep 6, 2018
@ocramz
Copy link
Owner

ocramz commented Sep 6, 2018

@gilgamec Hi, good catch; this is inconsistent. The API has been in need of attention for quite some time now. If you have an idea on how to fix this I'll happily merge a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants