Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose imapSM, correct imapIM2, and change to alter #75

Merged
merged 8 commits into from
Sep 28, 2019

Conversation

GregorySchwartz
Copy link
Contributor

imapSM is needed for many processes and is much better than flattening then building the matrix again to map over indices. I fixed the imapIM2 issue referenced in #74 and changed insert to alter for more speedup and better memory usage.

@GregorySchwartz
Copy link
Contributor Author

Also strict foldl' is necessary for faster transposing.

@GregorySchwartz
Copy link
Contributor Author

Can these changes be included in the next upload, along with the toRowsL / fromRowsL fix (which is already committed I believe)? I have some code relying on my fork where I would prefer to have it rely on the main Hackage release.

@GregorySchwartz
Copy link
Contributor Author

Is it possible to get this merged and released relatively soon?

@ocramz ocramz self-assigned this Sep 28, 2019
Copy link
Owner

@ocramz ocramz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks you !

@ocramz
Copy link
Owner

ocramz commented Sep 28, 2019

Sorry for the slow feedback and thank you for looking into performance issues! 👍

@ocramz ocramz merged commit dbad792 into ocramz:master Sep 28, 2019
@GregorySchwartz
Copy link
Contributor Author

Thanks! Will there be a release on hackage?

@ocramz
Copy link
Owner

ocramz commented Oct 10, 2019

@GregorySchwartz yes, but first I'd like to bring back master to feature parity with the current latest hackage release. I commented out a few things (see https://github.com/ocramz/sparse-linear-algebra/blob/master/src/Numeric/LinearAlgebra/Sparse.hs) in order to get rid of the MonadIO constraint and while settling on a decent effect type (something like Iterative here : https://github.com/ocramz/sparse-linear-algebra/blob/master/src/Control/Iterative/Internal.hs ) . After this is done I indend to push out a new release, I just don't know when I will have the bandwidth to do this; could be a few more weeks.

GregorySchwartz pushed a commit to GregorySchwartz/sparse-linear-algebra that referenced this pull request Aug 21, 2020
Expose imapSM, correct imapIM2, and change to alter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants