Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing version in META file #1042

Open
hhugo opened this issue Nov 25, 2024 · 5 comments
Open

Missing version in META file #1042

hhugo opened this issue Nov 25, 2024 · 5 comments

Comments

@hhugo
Copy link
Member

hhugo commented Nov 25, 2024

Starting with lwt 5.8.0 (lwt 5.7.0 is fine), the version is missing from lwt META's files.

The version in the META can be queried by ocamlfind. Some packages query it to check their dependencies.

Actual behavior

$ ocamlfind query lwt -format %v
[unspecified]

Expected behavior

$ ocamlfind query lwt -format %v
5.{8,9}.0

In 5.7.0, the version was present in the opam files. I suspect, but I'm not 100% confident, that dune extracts this info to generate the META.

In 5.8.0 and above, opam files are generated from dune-project but dune-project doesn't contain any version info.

In js_of_ocaml, I use dune-release to release packages and dune-release distrib create an archive with a dune-project file updated with the correct version.

@raphael-proust
Copy link
Collaborator

Thanks, I'll make a 5.8.1 and mark 5.8 as avoid-version in opam-repository.

raphael-proust added a commit that referenced this issue Jan 3, 2025
so that they appear in META files
see #1042
@raphael-proust
Copy link
Collaborator

@raphael-proust
Copy link
Collaborator

doesn't seem to fix the ocamlfind version…

I'll investigate when I have time

@raphael-proust
Copy link
Collaborator

trying to add the package version information right into the dune-project file now

@raphael-proust
Copy link
Collaborator

works for 5.8.1

I'll mark 5.8.0 as avoid-version, and do the same for 5.9

@ocsigen ocsigen deleted a comment from Mihail79482 Jan 6, 2025
@ocsigen ocsigen deleted a comment from Mihail79482 Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants