CI: Protecting Semantic Release before merging

[oscard0m]

Hi all!

Opening a discussion / brainstorming on how we could improve our Pull Requests Semantic Commits. This discussion is inspired by the thread in this issue.

It would be nice to find a way to prevent merging a PR with a commit (if squashed) or set of commits (if not squashed) accomplishing Semantic Commit rules to preserve and assure all the flows around Semantic Release in Octokit Ecosystem are archived.

At the same time, it would be important to remove friction to contributors when working in a PR and not forcing them to make all commits semantic if they plan to squash.

---

@G-Rath come up with a proposal here: octokit/webhooks@8506555

[oscard0m]

@G-Rath in your proposal the same issue you pointed would happen right?

PRs often end up without complete green tickets so the UI makes it look like its not in a good state to be merged

[G-Rath]

No, because the CI would either pass or fail - the app however has a third state: "nothing is semantic".

(See this comment for more)

[wolfy1339]

If we use https://github.com/apps/semantic-pull-requests then changing the PR title would be sufficient to make the test pass

[oscard0m]

If we use github.com/apps/semantic-pull-requests then changing the PR title would be sufficient to make the test pass

Which would be a desired or an undesired behavior?

[G-Rath]

Sorry it's been a while since I've used it so I'm a bit fuzzy on the details, but iirc it was actually about conditions on merging:

The app cannot require you to merge or squash a PR, so it can report that a PR is semantic because it's got a single semantic commit which it expects you'll merge rather than squash.

Then you squash the PR, making the non-semantic title the commit message and boom you've got a non-semantic message in your branch.

I'm not fussed with what we use - I just found it was a better experience using commitlint 🤷

[gr2m]

GitHub Action would be to slow for this use case. I'd build a separate app. We could collaborate on it if you like?

[oscard0m]

GitHub Action would be to slow for this use case. I'd build a separate app. We could collaborate on it if you like?

Count me in!

[gr2m]

I invited you to https://github.com/gr2m/squash-commit-app/invitations, lets continue discussion there :)

[G-Rath]

Sorry, we couldn't find that repository invitation. It is possible that the invitation was revoked or that you are not logged into the invited account.

😢

[gr2m]

@G-Rath Try again :)

[oscard0m]

Just to follow up on this. The GitHub app was created 🍾 🍾 🍾 🍾
https://github.com/apps/squash-commit-app

[gr2m]

Great work :)

I've installed it on all relevant @octokit repositories, let's see how it goes!

I think we would need a slightly different version which takes the semantic commit conventions into account, but let's see how the current version plays out first

[oscard0m]

Great work :)

I've installed it on all relevant @octokit repositories, let's see how it goes!

I think we would need a slightly different version which takes the semantic commit conventions into account, but let's see how the current version plays out first

Sure!