Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prevent redirection issue when clicking text or icon within button #6

Closed
wants to merge 5 commits into from

Conversation

rsdeus
Copy link
Member

@rsdeus rsdeus commented Oct 16, 2024

🎩 What? Why?

This fix resolves the issue where clicking on the text or icon inside a button would fail to trigger the correct redirection, as event.target would capture the inner elements (<span> or <icon>) instead of the <a> element containing the data-dialog-open attribute.

📌 Related Issues

Testing

  • Given a Decidim proposal component configured to accept participant proposals
  • As a non-registred user, I click on "New Proposal" text or "+" icon
    Captura de tela de 2024-10-16 11-00-19
  • I complete my login/password credentials and login
  • Error: I am back on the proposals component
  • Expected: I go on the proposal creation, as I clicked to "New Proposal" button

♥️ Thank you!

@rsdeus rsdeus requested a review from froger October 16, 2024 14:04
@rsdeus rsdeus self-assigned this Oct 16, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@froger
Copy link
Member

froger commented Nov 28, 2024

Proposed in decidim. closing

@froger froger closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants