Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the linter #166

Open
kit-ty-kate opened this issue Apr 18, 2022 · 2 comments
Open

Improve the linter #166

kit-ty-kate opened this issue Apr 18, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers linting

Comments

@kit-ty-kate
Copy link
Contributor

E.g.

  • Check that depopts has no filters
  • Check that on new packages there is no upper-bounds
  • Check that > and <= are not used in constraints
  • Check that = is not used in constraints (except for {= version})
@kit-ty-kate kit-ty-kate added enhancement New feature or request good first issue Good for newcomers labels Apr 18, 2022
@shonfeder
Copy link
Contributor

More context from @mseri:

The only ones that I would like as warning but should not fail are

  • Check that on new packages there is no upper-bounds
  • Check that = is not used in constraints (except for {= version})

Because there are packages that use both of those for reasonable reasons
But

  • Check that > and <= are not used in constraints
  • Check that depopts has no filters

are bounds that we tripped over multiple times and would really be useful. The second is actually wrong all the times it happens

@shonfeder
Copy link
Contributor

re: he "filters on depopts", what we need is

a lint that checks that no bound is on the depopts (They should be marked at conflicts)
(see ocaml/opam-repository#27033 for a case)

That is, instead of inclusive bounds on depopts, one should mark which packages are out of bonds as conflicts.

@shonfeder shonfeder changed the title TODO: Improve the linter Improve the linter Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers linting
Projects
None yet
Development

No branches or pull requests

2 participants