Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split statuses into required and warning/advisory #326

Open
shonfeder opened this issue Jun 17, 2024 · 0 comments
Open

Split statuses into required and warning/advisory #326

shonfeder opened this issue Jun 17, 2024 · 0 comments

Comments

@shonfeder
Copy link
Contributor

Currently, and for quite some time to come, opam repo maintainers have to exercise a lot of discretion in which CI failures they accept when merging packages. Eventually, we would like this to be fully automated, but in the meantime we can at least make the process easier via a more useful partitioning of the signals we send to github.

  • CI results should broken out into two categories, warnings and errors.
  • Results sent to github as statuses should be grouped accordingly.
  • Once this is done, we can enable branch protection rules on the opam repo side.

This will prevent certain classes of errors we currently encounter from time to time, such as ocaml/opam-repository#26046 (comment)

Required checks should include:

  • Reliable, binary linting checks
  • The package building on supported platforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant