Invalid local reproduction Dockerfile

[dra27]

cf. ocurrent/obuilder#66.

The final RUN command being produced is not valid:

RUN  \
    opam remove -y leveldb.1.3.0 && opam depext -uivy leveldb.1.3.0 \
    res=$? \
    test "$res" = 0 && exit 0 \
    if test "$res" = 60 && diff -q /usr/bin/opam /usr/bin/opam-2.0; then \
    sudo ln -f /usr/bin/opam-2.1 /usr/bin/opam \
    opam remove -y leveldb.1.3.0 && opam install -vy leveldb.1.3.0 && opam reinstall -vyt leveldb.1.3.0 \
    exit 1 \
    fi \
    test "$res" != 31 && exit 1 \
    export OPAMCLI=2.0 \
    build_dir=$(opam var prefix)/.opam-switch/build \
    failed=$(ls "$build_dir") \
    for pkg in $failed; do \
    if opam show -f x-ci-accept-failures: "$pkg" | grep -qF "\"alpine-3.12\""; then \
    echo "A package failed and has been disabled for CI using the 'x-ci-accept-failures' field." \
    fi \
    done \
    exit 1 \
    

[dra27]

There are three possible solutions:

1. Generate a script with a here document earlier in the instructions (like the opam-repository clone) and RUN that instead
2. Hoist the shell script into the pipeline
3. Add the missing semi-colons

[dra27]

Diff for option 3:

--- a   2021-03-22 09:49:41.685481622 +0000
+++ b  2021-03-22 09:47:14.055174720 +0000
@@ -1,19 +1,19 @@
 RUN  \
-    opam remove -y leveldb.1.3.0 && opam depext -uivy leveldb.1.3.0 \
-    res=$? \
-    test "$res" = 0 && exit 0 \
+    opam remove -y leveldb.1.3.0 && opam depext -uivy leveldb.1.3.0; \
+    res=$?; \
+    test "$res" = 0 && exit 0; \
     if test "$res" = 60 && diff -q /usr/bin/opam /usr/bin/opam-2.0; then \
-    sudo ln -f /usr/bin/opam-2.1 /usr/bin/opam \
-    opam remove -y leveldb.1.3.0 && opam install -vy leveldb.1.3.0 && opam reinstall -vyt leveldb.1.3.0 \
-    exit 1 \
-    fi \
-    test "$res" != 31 && exit 1 \
-    export OPAMCLI=2.0 \
-    build_dir=$(opam var prefix)/.opam-switch/build \
-    failed=$(ls "$build_dir") \
+    sudo ln -f /usr/bin/opam-2.1 /usr/bin/opam; \
+    opam remove -y leveldb.1.3.0 && opam install -vy leveldb.1.3.0 && opam reinstall -vyt leveldb.1.3.0; \
+    exit 1; \
+    fi; \
+    test "$res" != 31 && exit 1; \
+    export OPAMCLI=2.0; \
+    build_dir=$(opam var prefix)/.opam-switch/build; \
+    failed=$(ls "$build_dir"); \
     for pkg in $failed; do \
     if opam show -f x-ci-accept-failures: "$pkg" | grep -qF "\"alpine-3.12\""; then \
-    echo "A package failed and has been disabled for CI using the 'x-ci-accept-failures' field." \
-    fi \
-    done \
+    echo "A package failed and has been disabled for CI using the 'x-ci-accept-failures' field."; \
+    fi; \
+    done; \
     exit 1 \

[kit-ty-kate]

Fixed in #96