entries for staging and production #21
Conversation
|
I developed the following:
Something else should be inspected? |
templates/deployment.yaml
Outdated
| @@ -138,6 +138,42 @@ spec: | |||
| readOnly: true | |||
| {{- end }} | |||
|
|
|||
| - name: {{ .Chart.Name }}-job-scanner-staging | |||
There was a problem hiding this comment.
deployment and staging are two deployments of the chart, you do not need both inside the chart.
templates/deployment.yaml
Outdated
| - | | ||
| unset json | ||
|
|
||
| dispatcher_state=$(<dispatcher-state.json) |
templates/deployment.yaml
Outdated
|
|
||
| - name: {{ .Chart.Name }}-job-scanner-production | ||
| image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}" | ||
| command: ["oda_api"] |
There was a problem hiding this comment.
Better set the command to bash and write bash script as the second arg
templates/deployment.yaml
Outdated
| job_id=`echo "$i" | jq -r '.job_id'`; | ||
| request_completed=`echo "$i" | jq '.job_status_data[].request_completed'`; | ||
| if [[ $request_completed != *"true"* ]]; then | ||
| uncompleted_job_ids+=($job_id); |
There was a problem hiding this comment.
and then what happens to uncompleted_job_ids variable?
There was a problem hiding this comment.
I understood we wanted to potentially re-submit those uncompleted jobs...otherwise what do we do with them?
There was a problem hiding this comment.
Ok, so propose a command to resubmit?
There was a problem hiding this comment.
now it extracts, when possible, instrument product_query and job_id, and resubmit the same request
| command: ["bash"] | ||
| args: | ||
| - | | ||
| oda-api -u DISPATCHER_URL inspect --group-by-job; |
There was a problem hiding this comment.
I think what would be good to add is some kind of failsafe, i.e. when this whole script fails the container should not crash.
Else it can not be deployed and it's annoying. And for an optional feature like this it should get deployed anyway.
No description provided.