Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we have a nice notebook view modal in case of the failure? I think we talked about it? #244

Open
volodymyrss opened this issue Apr 11, 2024 · 4 comments
Assignees

Comments

@volodymyrss
Copy link
Member

image

@burnout87
Copy link
Collaborator

burnout87 commented Apr 11, 2024

Yes, and the button is indeed visible.

Now the question is why is it not enabled? Enabling takes place under the following conditions:

  • the instrument has to support the return progress (eg 'support_return_progress' => 'true' , oda-hub/frontend-tab-generator@9c5a4e1 ), was this change applied to the instrument you tested?
  • a status of progress or ready must have been returned, was it the case?
    • if not the case, could it be that the notebook output was generated by the nb2service in the backend, but yet neither the status progress or ready were returned?

for which instrument/product was the request?

@burnout87
Copy link
Collaborator

burnout87 commented Apr 11, 2024

Yes, and the button is indeed visible.

Now the question is why is it not enabled? Enabling takes place under the following conditions:

  • the instrument has to support the return progress (eg 'support_return_progress' => 'true' , oda-hub/frontend-tab-generator@9c5a4e1 ), was this change applied to the instrument you tested?

    • a status of progress or ready must have been returned, was it the case?

I just checked for the instrument HESS (I think that is the one), and I could verify that a status of ready was actually returned, and what is missing is the adaptation of the attributes of the instrument

@volodymyrss
Copy link
Member Author

I just checked for the instrument HESS (I think that is the one), and I could verify that a status of ready was actually returned, and what is missing is the adaptation of the attributes of the instrument

I don't remember, why is this custom setting needed? Can it be not always shown if available?

Also, here
image

There is a duplication, no?

@burnout87
Copy link
Collaborator

I don't remember, why is this custom setting needed? Can it be not always shown if available?

The button is visible, just not enabled if the functionality is not supported by the instrument. I included that so that instruments that do not support return progress (eg integral instruments), never show the button enabled, even if they return progress or ready status.

The "inspect notebook" link would disappear with oda-hub/dispatcher-plugin-nb2workflow#94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants