Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing / (slash) from https:// in destination images. #1501

Open
narfeta opened this issue Sep 14, 2024 · 6 comments
Open

Missing / (slash) from https:// in destination images. #1501

narfeta opened this issue Sep 14, 2024 · 6 comments
Labels

Comments

@narfeta
Copy link

narfeta commented Sep 14, 2024

Describe the bug
Some image href links are not set correctly. In my case, when I use a VirtualService to access the service, the images are not rendering properly. As you can see in the screenshot, a / is missing from the https://

To Reproduce
Steps to reproduce the behavior:

  1. Install odigos
  2. Got to destinations
  3. Click on Add a destination
  4. Inspect html

Expected behavior
Render images from destinations

Screenshots
imagem
imagem
imagem
imagem
imagem

@alonkeyval
Copy link
Collaborator

Thanks for bringing it to our attention, @narfeta. we will take a look.

@alonkeyval
Copy link
Collaborator

Hey @narfeta, can you share your VirtualService configuration yaml?

@narfeta
Copy link
Author

narfeta commented Sep 22, 2024

sure, let me know if you need any other information.

apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: odigos-ui
  namespace: odigos-system
spec:
  gateways:
  - default/gtw-priv-https
  hosts:
  - odigos.mydomain.com
  http:
  - name: odigos-ui
    route:
    - destination:
        host: ui
        port:
          number: 3000

@alonkeyval
Copy link
Collaborator

alonkeyval commented Sep 23, 2024

it could help to explicitly define a rewrite rule to ensure URLs are correctly formatted when passed to the destination service.
this ensures that no extra slashes are added or removed, meaning it keeps the URI path exactly as it is without modification.

http:
  - name: odigos-ui
    match:
      - uri:
          prefix: /  # Match all paths
    rewrite:
      uri: /  # Ensure no slashes are stripped or incorrectly modified
    route:
    - destination:
        host: ui
        port:
          number: 3000

@narfeta let me know if this helps :)

@narfeta
Copy link
Author

narfeta commented Sep 23, 2024

Sadly no :( the problem continues.

imagem imagem

Thank you for the time to look into this.

Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants