Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style ODK-X Survey Instance Savepoints-types #210

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

juayuohcarineneng19
Copy link
Contributor

@juayuohcarineneng19
Copy link
Contributor Author

Hi @Redeem-Grimm-Satoshi @wbrunette @maprehensive Please can you review this.

@juayuohcarineneng19 juayuohcarineneng19 changed the title Style Instance Savepoints-types Style ODK-X Survey Instance Savepoints-types Jul 3, 2024
@juayuohcarineneng19 juayuohcarineneng19 changed the base branch from main to development July 3, 2024 01:45
Comment on lines 633 to 655
.savepoints.finalized {
display: flex;
text-align: center;
align-items: center;
width: fit-content;
padding: 16px;
justify-content: center;
color: #1CCB3D;
background-color: #F0FDF2;
height: 40px;
}

.savepoints.incomplete {
display: flex;
text-align: center;
align-items: center;
width: fit-content;
padding: 16px;
justify-content: center;
color: #DF961F;
background-color: #FCF8EA;
height: 40px;
}
Copy link
Member

@Redeem-Grimm-Satoshi Redeem-Grimm-Satoshi Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juayuohcarineneng19 I don't see any border-radius, did you leave this out intentionally?

Those states have a border-radius on the design screen but I can't see it here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juayuohcarineneng19 I don't see any border-radius, did you leave this out intentionally?

Those states have a border-radius on the design screen but I can't see it here

Hi @Redeem-Grimm-Satoshi I have added border-radius .

@Redeem-Grimm-Satoshi
Copy link
Member

Redeem-Grimm-Satoshi commented Aug 13, 2024

...

@wbrunette wbrunette requested a review from r0ssing August 13, 2024 15:43
@Redeem-Grimm-Satoshi
Copy link
Member

@r0ssing Please just go ahead and merge this. Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants