-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style ODK-X Survey Instance Savepoints-types #210
Open
juayuohcarineneng19
wants to merge
5
commits into
odk-x:development
Choose a base branch
from
juayuohcarineneng19:savepoint-types
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6e4d4ac
style instance savepoint-types
juayuohcarineneng19 dec0de6
Add border radius to states
juayuohcarineneng19 6f7ab5f
add borders to states
juayuohcarineneng19 3062497
add borders to states
juayuohcarineneng19 9e88f06
Merge branch 'development' into savepoint-types
juayuohcarineneng19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,62 +1,62 @@ | ||
| <div> | ||
| <div> | ||
| <center><img src="{{ headerImg }}" class="odk-formlogo" /></center> | ||
| <hr> | ||
| </div> | ||
| {{{localizeText display.instances_survey_form_identification}}} | ||
| <div class="instanceClearDiv"></div> | ||
| <div> | ||
| <fieldset class="instanceNew"> | ||
| <div class="row"> | ||
| <div> | ||
| <button type="button" class="createInstance btn btn-default" tabindex="0">{{localizeText display.new_button_label}} | ||
| <span class="glyphicon glyphicon-plus-sign" style="font-size:20px;"></span> | ||
| </button> | ||
| </div> | ||
| </div> | ||
| </fieldset> | ||
| <hr> | ||
| </div> | ||
| {{{localizeText display.instances_previously_created_instances_label}}} | ||
| <hr> | ||
| <div class="instanceList"> | ||
| <ul class="list-group"> | ||
| {{#each instances}} | ||
| {{#if dateDivider}} | ||
| <li class="list-group-item">{{dateDivider}}</li> | ||
| {{/if}} | ||
| <li class="list-group-item"> | ||
| <fieldset class="instanceListGrid"> | ||
| <div class="row"> | ||
| <div class="col-xs-8"> | ||
| <p><strong>{{display_field}}</strong></p> | ||
| {{{localizeText ../display.instances_last_save_date_label}}} | ||
| <p>{{savepoint_timestamp}}</p> | ||
| <p><strong>{{localizeText savepoint_type_text}}</strong></p> | ||
| {{#if is_checkpoint}} | ||
| <span class="glyphicon glyphicon-warning-sign"></span></p> | ||
| {{/if}} | ||
| </div> | ||
| <div class="col-xs-4"> | ||
| <div class="instanceRowControl btn-group"> | ||
| <button type="button" id="{{instance_id}}" class="odk openInstance btn btn-default" tabindex="0"> | ||
| <span class="glyphicon glyphicon-pencil" style="font-size:20px;"> | ||
| </button> | ||
| {{#if show_delete}} | ||
| <button type="button" id="{{instance_id}}" display_value="{{display_field}}" class="odk deleteInstance btn btn-default" tabindex="0"> | ||
| <span class="glyphicon glyphicon-remove-sign" style="font-size:20px;"> | ||
| </button> | ||
| {{/if}} | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </fieldset> | ||
| </li> | ||
| {{else}} | ||
| <li>{{localizeText display.instances_no_saved_instances_label}}</li> | ||
| {{/each}} | ||
| </ul> | ||
| </div> | ||
| </div> | ||
| <div> | ||
| <div> | ||
| <center><img src="{{ headerImg }}" class="odk-formlogo" /></center> | ||
| <hr> | ||
| </div> | ||
| {{{localizeText display.instances_survey_form_identification}}} | ||
|
|
||
| <div class="instanceClearDiv"></div> | ||
| <div> | ||
| <fieldset class="instanceNew"> | ||
| <div class="row"> | ||
| <div> | ||
| <button type="button" class="createInstance btn btn-default" tabindex="0">{{localizeText display.new_button_label}} | ||
| <span class="glyphicon glyphicon-plus-sign" style="font-size:20px;"></span> | ||
| </button> | ||
| </div> | ||
| </div> | ||
| </fieldset> | ||
| <hr> | ||
| </div> | ||
|
|
||
| {{{localizeText display.instances_previously_created_instances_label}}} | ||
| <hr> | ||
| <div class="instanceList"> | ||
| <ul class="list-group"> | ||
| {{#each instances}} | ||
| {{#if dateDivider}} | ||
| <li class="list-group-item">{{dateDivider}}</li> | ||
| {{/if}} | ||
| <li class="list-group-item"> | ||
| <fieldset class="instanceListGrid"> | ||
| <div class="row"> | ||
| <div class="col-xs-8"> | ||
| <p><strong>{{display_field}}</strong></p> | ||
| {{{localizeText ../display.instances_last_save_date_label}}} | ||
| <p>{{savepoint_timestamp}}</p> | ||
| <p class="savepoints {{status_class}}"><strong>{{localizeText savepoint_type_text}}</strong></p> | ||
| {{#if is_checkpoint}} | ||
| <span class="glyphicon glyphicon-warning-sign"></span></p> | ||
| {{/if}} | ||
| </div> | ||
| <div class="col-xs-4"> | ||
| <div class="instanceRowControl btn-group"> | ||
| <button type="button" id="{{instance_id}}" class="odk openInstance btn btn-default" tabindex="0"> | ||
| <span class="glyphicon glyphicon-pencil" style="font-size:20px;"> | ||
| </button> | ||
| {{#if show_delete}} | ||
| <button type="button" id="{{instance_id}}" display_value="{{display_field}}" class="odk deleteInstance btn btn-default" tabindex="0"> | ||
| <span class="glyphicon glyphicon-remove-sign" style="font-size:20px;"> | ||
| </button> | ||
| {{/if}} | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </fieldset> | ||
| </li> | ||
| {{else}} | ||
| <li>{{localizeText display.instances_no_saved_instances_label}}</li> | ||
| {{/each}} | ||
| </ul> | ||
| </div> | ||
| </div> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juayuohcarineneng19 I don't see any border-radius, did you leave this out intentionally?
Those states have a border-radius on the design screen but I can't see it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Redeem-Grimm-Satoshi I have added border-radius .