Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODK-X Tables - set the status bar color #364

Open
maprehensive opened this issue Oct 2, 2022 · 34 comments
Open

ODK-X Tables - set the status bar color #364

maprehensive opened this issue Oct 2, 2022 · 34 comments
Assignees
@wadva474 @salmasabo @Pamela-owino @JessicaItepu
Labels
good first issue Good for newcomers Outreachy Winter 2022 user interface uplift

Comments

@maprehensive
Copy link
Contributor

maprehensive commented Oct 2, 2022 •
edited
Loading

Set the color of the app status bar to match the app background color in ODK-X Tables.

Screen Shot 2022-10-02 at 09 40 09
Example of the default status bar color (left) and status bar color changed to match the app background (right)

Why this needs to be improved:

  • the menu bar in the application looks crowded by the default grey status bar

Guidance for this issue:

  • Change settings in styles.xml or theme.xml
  • Light mode: <item name="android:navigationBarColor" tools:targetApi="21">@color/white</item>
  • For dark mode see design guidelines below

Guidelines:

This issue is referenced on slide 12 of the ODK-X Design Guidelines

Outreachy

This issue can be used for an Outreachy application for the project Custom UI components for ODK-X mobile apps
This issue is for the Technical stream of the project.

Please request to be assigned to the issue so we can track the number of peopling doing this exercise. Multiple people can work on this issue simultaneously.

You do not need to be assigned to this issue to work on it for an Outreachy application
@maprehensive maprehensive changed the title ODK-X Tables - set the navigation bar color ODK-X Tables - set the status bar color Oct 2, 2022
@Redeem-Grimm-Satoshi
Copy link
Member

@maprehensive can I work on this?

@salmasabo
Copy link

I would like to work on this issue

@maprehensive
Copy link
Contributor Author

@Redeem-Grimm-Satoshi since I've assigned you to #365 I will assign this to the next requester.

@salmasabo Thanks! You are assigned to this issue.

@Augusta2
Copy link

Augusta2 commented Oct 9, 2022

Hello, I will love to work on this.

@Pamela-owino
Copy link

Hello @maprehensive , can I be assigned to this issue?

@Augusta2
Copy link

Good day @maprehensive, I am from Outreachy and this is my first time working with GitHub.
I can't seem to find the file I need to work on. Can you point me in the right direction? Thank you

@wadva474
Copy link

@Augusta2 , the changes you need to make is in the android Library Project
https://github.com/odk-x/androidlibrary

you can read the guide on setting up tables project https://github.com/odk-x/tables/#setting-up-your-environment
@maprehensive , i can also join @Augusta2 to work on the issue and implementing the app bar dark mode .

@JessicaItepu
Copy link

Hello, i would love to work on this project. Could you please assign it to me.

@Augusta2
Copy link

Augusta2 commented Oct 10, 2022 •
edited
Loading

Thanks for your reply.
@wadva474

@Joyfro
Copy link

Joyfro commented Oct 12, 2022

Hi, I would love to work on this issue. could you please assign it to me? @maprehensive

@salmasabo
Copy link

@Redeem-Grimm-Satoshi since I've assigned you to #365 I will assign this to the next requester.

@salmasabo Thanks! You are assigned to this issue.

Thank you.!
I have began work on it already.

@Augusta2 Augusta2 removed their assignment Oct 13, 2022
@NiranjanNlc
Copy link

I would like to work on this issuse .

@maprehensive
Copy link
Contributor Author

@NiranjanNlc Thanks! You can work on this issue without being assigned.

@wadva474
Copy link

@maprehensive , i have created a PR to address the issue

odk-x/androidlibrary#235

@NiranjanNlc
Copy link

@NiranjanNlc Thanks! You can work on this issue without being assigned.

Hey @maprehensive , I have created a pull request to address the issuse .
I have verified for both light and dark mode on my device .

@maprehensive
Copy link
Contributor Author

odk-x status bar redesign

@maprehensive thia is my submission on the given project

Thanks @JessicaItepu - nicely laid out! Have you submitted a pull request with the changes?

@Cveman1
Copy link
Member

Cveman1 commented Oct 16, 2022

@NiranjanNlc Thanks! You can work on this issue without being assigned.

Hey @maprehensive , I have created a pull request to address the issuse . I have verified for both light and dark mode on my device .

I love the way this looks @NiranjanNlc

@JessicaItepu
Copy link

Hello. @salmasabo, for your image to show i think you have to put it first. That is select image first .. then add your comment.

@salmasabo
Copy link

Hello. @salmasabo, for your image to show i think you have to put it first. That is select image first .. then add your comment.

Hi Jessica,thank you for letting me know,let me correct it now.

@JessicaItepu
Copy link

Screenshot_20221019-182809_Samsung Internet

Did your picture show this long text before you hit send?

@salmasabo
Copy link

Yes it did,looks like it's still not showing the image right.?

@JessicaItepu
Copy link

No, its not showing. Try resaving it. From your design app

@Redeem-Grimm-Satoshi
Copy link
Member

Redeem-Grimm-Satoshi commented Oct 19, 2022 via email

@Redeem-Grimm-Satoshi
Copy link
Member

Redeem-Grimm-Satoshi commented Oct 19, 2022 via email

@salmasabo
Copy link

Hello i need your help. How can i contact you outside this forum. @salmasabo

Okay,Hit me up on slack

@JessicaItepu
Copy link

Redeem Grimm here
…
On Wed, Oct 19, 2022, 8:57 PM Ram Automi @.> wrote: @jessica I've replied you on ODK-X forum On Wed, Oct 19, 2022, 7:33 PM JessicaItepu @.> wrote: > Hello i need your help. How can i contact you outside this forum. > @salmasabo https://github.com/salmasabo > > — > Reply to this email directly, view it on GitHub > <#364 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/AKZUZEQUAMWEE6L25IL5UOLWEA5FZANCNFSM6AAAAAAQ2V6DTY > . > You are receiving this because you were mentioned.Message ID: > @.***> >

Ohhhhh. I am so sorry. Just got the mail.

@wadva474 wadva474 mentioned this issue Oct 20, 2022
Open
@wadva474
Copy link

@maprehensive i have created a PR to address the issue

@salmasabo
Copy link

6
@maprehensive here's my submission to the issue.

@JessicaItepu
Copy link

Not showing @salmasabo

@NiranjanNlc NiranjanNlc mentioned this issue Oct 21, 2022
Open
@JessicaItepu
Copy link

Hello @maprehensive, my previous submission to this issue was a designed one as at the time i didn't know the issue was technical.

Noe i have created a Pull request adressing it technically. This pull request covers the changes in all the ODK apps and their screenshots. Thank you

@JessicaItepu
Copy link

Thank you @Redeem-Grimm-Satoshi for taking your time to put me through on things that were difficult before. 🙏. I hope the review is positive.

@Cveman1
Copy link
Member

Cveman1 commented Oct 24, 2022

Awesome work @JessicaItepu

Wow. You really used the code editor finally

@ghost
Copy link

ghost commented Nov 3, 2022

Hi @maprehensive i have tried for days to create a PR on issue #364 but it seems not okay. But then here's my submission for issue #364.

The target API is from version 21

<style name="OdkActionBar" parent="Widget.AppCompat.Light.ActionBar.Solid"> useLogo|showHome|showTitle @color/white @drawable/app_logo </style> 
<style name="Opendatakit" parent="Theme.AppCompat.Light">
    <item name="android:statusBarColor" tools:targetApi="21">@android:color/white</item>
    <item name="android:scrollbarThumbHorizontal">@drawable/thumb</item>
    <item name="android:scrollbarThumbVertical">@drawable/thumb</item>
    <item name="android:scrollbarSize">2.5mm</item>
    <item name="android:scrollbarAlwaysDrawVerticalTrack">true</item>
    <item name="android:scrollbarAlwaysDrawHorizontalTrack">true</item>
    <item name="actionBarStyle">@style/OdkActionBar</item>
    <item name="preferenceTheme">@style/PreferenceThemeOverlay.v14.Material</item>
</style>

@Redeem-Grimm-Satoshi
Copy link
Member

Redeem-Grimm-Satoshi commented Nov 4, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wadva474 wadva474

@salmasabo salmasabo

@Pamela-owino Pamela-owino

@JessicaItepu JessicaItepu

Labels
good first issue Good for newcomers Outreachy Winter 2022 user interface uplift
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@maprehensive @NiranjanNlc @wadva474 @Redeem-Grimm-Satoshi @Cveman1 @Joyfro @salmasabo @Pamela-owino @Augusta2 @JessicaItepu