You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In BoostSupport.cxx queryImpl(), the response to the query (const auto response = transport->query(querty);) returns a JSON string and then loaded into a ptree.
so, all field data is represented as a string in the ptree.
If you agree with the changes in #113, all fields will end up being stored as a string with actual strings being inserted double quoted.
So the following code int Point.cxx will need to change:
convert << field.first << "=";
std::visit(overloaded {
[&convert](int v) { convert << v << 'i'; },
[&convert](long long int v) { convert << v << 'i'; },
[&convert](double v) { convert << std::fixed << v; },
[&convert](const std::string& v) { convert << '"' << v << '"'; },
}, field.second);
at a minimum { convert << '"' << v << '"'; } needs to change to { convert << v; }
So, all fields will be string representations. Let the consumer of the field data do the conversion.
Or add code to BoostSupport.cxx to decide the data types and convert prior to insertion in the point.
The text was updated successfully, but these errors were encountered:
In BoostSupport.cxx queryImpl(), the response to the query (const auto response = transport->query(querty);) returns a JSON string and then loaded into a ptree.
so, all field data is represented as a string in the ptree.
See ticket #113!
If you agree with the changes in #113, all fields will end up being stored as a string with actual strings being inserted double quoted.
So the following code int Point.cxx will need to change:
convert << field.first << "=";
std::visit(overloaded {
[&convert](int v) { convert << v << 'i'; },
[&convert](long long int v) { convert << v << 'i'; },
[&convert](double v) { convert << std::fixed << v; },
[&convert](const std::string& v) { convert << '"' << v << '"'; },
}, field.second);
at a minimum { convert << '"' << v << '"'; } needs to change to { convert << v; }
So, all fields will be string representations. Let the consumer of the field data do the conversion.
Or add code to BoostSupport.cxx to decide the data types and convert prior to insertion in the point.
The text was updated successfully, but these errors were encountered: