Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor to es6 module #141

Open
alephpi opened this issue Jun 20, 2023 · 2 comments
Open

refactor to es6 module #141

alephpi opened this issue Jun 20, 2023 · 2 comments

Comments

@alephpi
Copy link

alephpi commented Jun 20, 2023 •
edited
Loading

hi, thanks for your excellent work!
I am trying to play it with vue and make use of tree-shakable feature with es6 modules. do you plan to refactor it (as well as bump the d3 dependency to latest version)? i know it will cost much time, do you have an idea how to do it? maybe i'll start from src/celestial.js.

thank you!
@alephpi alephpi changed the title bump to d3 latest refactor to es6 module Jun 20, 2023
@alephpi
Copy link
Author

alephpi commented Jun 22, 2023 •
edited
Loading

Hi, I'm looking into your source code now.
I wonder why here you divide by 1024 when compute the scale? Also, how did you get those 'magic' scale number for different projections? (e.g. aitoff scale is 162)

@alephpi
Copy link
Author

alephpi commented Jun 22, 2023

Hi, I'm looking into your source code now. I wonder why here you divide by 1024 when compute the scale? Also, how did you get those 'magic' scale number for different projections? (e.g. aitoff scale is 162)

see comment here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alephpi