Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Task class to support callbacks #38

Closed

Conversation

sgalpha01
Copy link

Update the model to support callback_url in view of the proposal: ga4gh/task-execution-schemas#121

@@ -266,6 +266,9 @@ class Task(Base):
description = attrib(
default=None, converter=strconv, validator=optional(instance_of(str))
)
callback_url = attrib(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment that this feature is for something that will be added into the TES specification in the future. Probably in version 1.2

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@sgalpha01 sgalpha01 force-pushed the add-callback-support branch from 022f859 to 8005509 Compare September 6, 2022 16:36
@uniqueg uniqueg added the TES 1.2.0 requires TES v1.2.0 release label Feb 9, 2023
@uniqueg
Copy link
Collaborator

uniqueg commented Feb 9, 2023

I have added blocked and TES 1.2.0 labels now. I think we can just leave this PR open until the feature is merged in TES 1.2.0. It might need a little update then (remove comment, add type hint), but I'm sure we will manage :)

@uniqueg uniqueg added the blocked cannot be processed now label Feb 9, 2023
@lbeckman314 lbeckman314 changed the base branch from master to develop January 8, 2024 23:36
@lbeckman314 lbeckman314 deleted the branch ohsu-comp-bio:develop December 6, 2024 23:37
@lbeckman314 lbeckman314 closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked cannot be processed now TES 1.2.0 requires TES v1.2.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants