Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor judger code #152

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Refactor judger code #152

merged 1 commit into from
Mar 28, 2024

Conversation

slhmy
Copy link
Member

@slhmy slhmy commented Mar 23, 2024

This PR merge judger-server into judger & remove judger-cli & judger-service.
Also, some unnecessary code in judger is erased (Ex. the judge API in judger).

Folder under judger is reorganized, so currently it becomes more similiar with the structure of oj-platform-service.

More option is take into the front to increase the flexibilty for judger launch.

@slhmy slhmy force-pushed the slhmy/refactor branch 5 times, most recently from dbd5de9 to 6e4c013 Compare March 23, 2024 12:07
@slhmy slhmy requested a review from akamya997 March 23, 2024 12:23
@slhmy slhmy marked this pull request as ready for review March 23, 2024 12:24
@slhmy slhmy self-assigned this Mar 23, 2024
@slhmy slhmy added the refactor label Mar 23, 2024
@Zztrans
Copy link
Member

Zztrans commented Mar 27, 2024

It seems structured like this:

  • cli -> agent, including platform and rclone.

  • service -> handler

  • worker.rs control agent and handler judge event flow.

  • main.rs listened to HTTP request and called the worker.

LGFM, which seems to be clearer.

Copy link
Contributor

@akamya997 akamya997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, they should be in a single module.

@slhmy
Copy link
Member Author

slhmy commented Mar 28, 2024

It seems structured like this:

  • cli -> agent, including platform and rclone.
  • service -> handler
  • worker.rs control agent and handler judge event flow.
  • main.rs listened to HTTP request and called the worker.

LGFM, which seems to be clearer.

Should be notice that, we still need service mod in the future. Sevice mod will hold a set of more logical funcs instead of web server handlers.

@slhmy slhmy merged commit 5b43c1e into main Mar 28, 2024
2 checks passed
@slhmy
Copy link
Member Author

slhmy commented Mar 28, 2024

I'm merging it since everyone think it's fine. But some feature may be broken after refactor.

@slhmy slhmy deleted the slhmy/refactor branch August 9, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants