Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification should say "you" / "your" for user's own proposal #2441

Closed
dotmacro opened this issue Dec 1, 2024 · 0 comments · Fixed by #2444
Closed

Notification should say "you" / "your" for user's own proposal #2441

dotmacro opened this issue Dec 1, 2024 · 0 comments · Fixed by #2444
Assignees
@SebinSong
Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc.

Comments

@dotmacro
Copy link
Member

dotmacro commented Dec 1, 2024

Problem

Notifications say "User's proposal..." (etc) even when the proposal was created by the current user. Per design, the copy should be "You" or "Your" when it's the current user's proposal.

image

Figma design:
https://www.figma.com/design/mxGadAHfkWH6qApebQvcdN/Group-Income-2.0?node-id=4486-2&node-type=frame&t=IjFm037vcyPjOrpz-0

Solution

Implement wherever applicable.
@dotmacro dotmacro added Kind:Enhancement Improvements, new features, performance upgrades, etc. App:Frontend labels Dec 1, 2024
@SebinSong SebinSong self-assigned this Dec 1, 2024
@SebinSong SebinSong mentioned this issue Dec 6, 2024
Merged
SebinSong added a commit that referenced this issue Dec 16, 2024
@SebinSong
Merge remote-tracking branch 'origin/master' into sebin/task/#2441-no…
e9d1111 
…tification-should-have-you
taoeffect pushed a commit that referenced this issue Dec 16, 2024
@SebinSong
#2441 - proposal notifications should have 'you' when I am the creator (
d4c870a 
#2444)

* update template for NEW_PROPOSAL

* update notification msg template for PROPOSAL_CLOSED

* update for feedback

* add comment

* install new pkg

* update for Greg CR

* comment update for the flaky cypress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SebinSong SebinSong

Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2441 - proposal notifications should have 'you' when I am the creator okTurtles/group-income
2 participants
@dotmacro @SebinSong