Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure menus expand in visible area #2448

Open
dotmacro opened this issue Dec 9, 2024 · 0 comments · May be fixed by #2456
Open

Ensure menus expand in visible area #2448

dotmacro opened this issue Dec 9, 2024 · 0 comments · May be fixed by #2456
Assignees
Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc.

Comments

@dotmacro
Copy link
Member

dotmacro commented Dec 9, 2024

Problem

"Create proposal v" menu does not always expand in visible area.

Steps to reproduce:

  1. Scroll to bottom of Dashboard (i.e. bottom of "Proposals" section).
  2. Tap "Create proposal v" to open menu
  3. See menu expand, but not fully onscreen (depending on height of "Proposals" section) <-- the problem
  4. Optionally, scroll to bottom of screen to see full list of proposal options
  5. Tap "Create proposal ^" to hide menu
  6. Menu disappears and bottom of "Proposals" section is properly spaced from bottom of screen (via shrink & auto-scrolling if necessary)

Short "Proposals" section means full menu of proposal types isn't visible
image

Sufficiently long "Proposals" section means full menu of proposal types is visible, no problem
image

Solution

  1. Ensure all proposal types are visible when menu is opened. Expanding the page and auto-scrolling so the full menu is visible (i.e. the opposite of functionality in step 6 above) would be a smooth way to do this.
  2. Optional: Align menu with right (preferred, current) or left (fallback if necessary) of "Create proposal v" button so that the menu is also fully visible left-to-right.
@dotmacro dotmacro added Kind:Enhancement Improvements, new features, performance upgrades, etc. App:Frontend labels Dec 9, 2024
@SebinSong SebinSong self-assigned this Dec 9, 2024
@SebinSong SebinSong linked a pull request Dec 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants