#1774, #1771 - Bug-fixes in Payment.vue #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebinSong
commented
Oct 20, 2023
| @@ -33,11 +33,12 @@ export default ({ | |||
| }, | |||
| computed: { | |||
| percent () { | |||
| return `${100 * this.value / this.max}%` | |||
| return !this.max ? '0%' : `${100 * this.value / this.max}%` | |||
There was a problem hiding this comment.
When max here is passed as 0, the percent value here becomes NaN% and leads to a UI bug. This is a fix for that issue.
There was a problem hiding this comment.
@SebinSong this would've been a great comment to add to the code... (￣ー￣；
taoeffect
requested changes
Oct 20, 2023
There was a problem hiding this comment.
Looking really good @SebinSong!
Two requests:
- See comment about adding a comment inline in the code instead of on Github
- I noticed that when the payments are reset because a payment was marked as not complete, the green checkboxes are not cleared:
Vs how they started out:
|
@taoeffect Good catch on that one. |
taoeffect
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1771
closes #1774