Fix issue #1789 #1802
Merged
Fix issue #1789 #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taoeffect
reviewed
Dec 30, 2023
Comment on lines
227
to
228
| // TODO: use .replaceAll when migrating to TS. | ||
| return humanDate(datems).replace(/\x20/g, '\xa0') |
There was a problem hiding this comment.
We can't we use .replaceAll now? 🤔
There was a problem hiding this comment.
Just because our Flow version would complain about it being a non-existent string property. Or maybe we could add a $FlowFixMe comment to use it now anyway
taoeffect
requested changes
Jan 11, 2024
Comment on lines
1
to
9
| const userId = Math.floor(Math.random() * 10000) | ||
| const groupName = 'Dreamers' | ||
| const usersDisplayName = { | ||
| 1: 'Greg', | ||
| 2: 'Margarida', | ||
| 3: 'Pierre', | ||
| 4: 'Sandrina' | ||
| } | ||
|
|
There was a problem hiding this comment.
This file seems to have been duplicated and added on accident? Can it be removed?
There was a problem hiding this comment.
Yea sure - renaming a specific test file this way is a method I use sometimes to have it run first
taoeffect
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Nice job @snowteamer!
EDIT: see comment: #1789 (comment) - think this issue is still open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1789
This quickfix PR addresses an issue where
timeSince()would replace2(\x32) characters instead of plain white spaces (\x20) by non-breaking spaces in its output, causing incorrect date display e.g. in notifications.