great docker build, a few questions

[holderl5]

Thank you for your docker build. It was exactly what I was looking for. I ran into a few issues, but before I do a pull request, I wanted to discuss with you to see if you are interested merging these. I ran into a few issues and ended up cloning and making a local build. Let me summarize what I changed:

• I updated the base to use Buster-slim as I think what was there before is EOL
• The current cache settings caused bizarre behavior. I could for example, click on FindPage link and only get the FindPage every 5 or 6 times. The other times, I would get various MissingPage pages, sometimes with suggestions, and sometimes just the single line to offer to create the page. I did not attempt to fix this, but removed it from my build as I would not need it for my purposes.
• The volume for the data not including /usr/local/share/moin would cause all underlay pages to be removed if the container was recreated. I changed this.
• I created a docker-compose.yml leaving the SSL entirely to jwilder/nginx-proxy as it is a one stop shop needing no code to configure SSL

[olavgg]

Thank you for your suggestions.

1. Changing to Buster-slim is no problem!
2. The cache settings seem to work here, but I have not done a full test on this. I would need to do some investigation.
3. This is a valid point, and I have no problem with changes here.
4. Using another webserver/service/container is entirely up to the end-user. I prefer people rather fork this project and configure this themself in their preferred setup. This container is supposed to be as simple as possible and for most people, I think not having to configure an additional webserver is preferred. The additional resource usage is minimal, and there is a configuration setting for disabling https.

[holderl5]

I am pretty full up, but let me get a pull request setup. It might take a while.

on (4):
I realize you have done a lot of work already on the SSL, but you should see how easy it is to use the jwilder proxy container. If I add a contrib directory with directions for doing this, would you have any objections?

[olavgg]

The work I've done on the SSL part is very simple, and replacing it with something else as long it benefits the users is of no problem for me. Using the jwilder proxy container, even if it is easy, is still a second step, and I don't believe most users want that second step. There is another excellent Moinmoin container which is very good for those who like configuration over convention -> https://github.com/dperson/moinmoin

I am taking a strong stand here, but I believe I do for the majority of users. Another solution may be opening for a configuration option that disables the embedded Nginx. But then again, perhaps just using https://github.com/dperson/moinmoin is better? :-)

[holderl5]

I will check those. If you are interested in the steps, I have an incomplete writeup here:

https://www.simulakrum.com/MoinMoinOnDocker.html

I will get back to you in a few weeks or so. Work has moved to a semi emergency state.