Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad profiling on specific sound #3

Open
robinrosenberger opened this issue Nov 29, 2020 · 4 comments
Open

Bad profiling on specific sound #3

robinrosenberger opened this issue Nov 29, 2020 · 4 comments

Comments

@robinrosenberger
Copy link

robinrosenberger commented Nov 29, 2020

First: Thanks for this software, it's really great to have an open source alternative to a Kemper!
I have one specific sound in BIAS AMP2 that reliably generates really bad profiles. It's not a serious problem, when I rebuild a similar sound I can't recreate the issue, but maybe its interesting to find out what the problem is in this specific setup.
I'll attach a carla-preset for BIAS AMP2, as well as the test signal reply (created by Ardour freeze, worked flawlessly on other sounds) and the resulting profile.
issue.zip

@olegkapitonov
Copy link
Owner

Thank you!

This will help a lot!

@olegkapitonov
Copy link
Owner

Very high bass level (20 Hz point), middle and treble points seem
to be quite normal. And 20 Hz test response signal is very weak.
This is why it fails - this BIAS profile doesn't pass 20 Hz bass sound.

I need to fix this case - if test response is too weak, profiler should not process it,
and should give reasonable predefined low value for this frequency.

I added the hack and set 20Hz response value manually and get this profile

bad-profile-hacked.tapf.zip

in my opinion, not bad.

I will fix this issue, but I need some time to make sure that this fix will not break other cases.

@robinrosenberger
Copy link
Author

Thanks for hacking the profile, although that was not my primary concern ;)
I think I added a quite aggressive low-cut on the input which might be the cause, I'll remove that and see what happens, and I will try to force the problem by adding one to an otherwise working setup. If it is the source of the problem I think an error message like "too low bass response" would be enough for a quick fix as well. Or make the default value an option, to avoid breaking the otherwise really impressive profiling?

@robinrosenberger
Copy link
Author

Confirmed, adding an EQ cutting the low end on a working setup results in this behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants