Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for silicone immersion objective #82

Open
carandraug opened this issue Aug 16, 2018 · 4 comments
Open

support for silicone immersion objective #82

carandraug opened this issue Aug 16, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@carandraug
Copy link

The Immersion enum does not have a value for silicone immersion. I'm using 'OTHER' at the moment, but I guess that Silicone could be have its own value. I found this missing while adding more ids for ome/bioformats#2656

@mtbc
Copy link
Member

mtbc commented Aug 17, 2018

Thank you indeed for the suggestion. Do you know if we already have an image file that includes silicone immersion? If maybe not then could you send us one (ideally a publicly sharable image) to http://qa.openmicroscopy.org.uk/qa/upload/ and let us know the QA number here? That way it is more likely to turn up when we review missing values and add them as in ome/bioformats#2553.

@carandraug
Copy link
Author

I'm not sure if you already have one, I don't think I have access to your QA images to check. It will be easy to test though, simply run the following on all your dv files, and if any returns a value of 10615, then it's was acquired with a silicone objective:

$ hexdump -e '"%d\n"' -s 162 -n 2 DAPI_60xSil-RT-165corrRing_20141024_88.otf 
10615

@sbesson
Copy link
Member

sbesson commented Aug 23, 2018

@carandraug some of our public Deltavision sample files are available on our downloads pages. I have executed your command against all our public and private samples but could not find a representative sample using this objective ID so we'd certainly be very interested in getting a representative file (ideally something that can be made public under CC-BY license).

@joshmoore
Copy link
Member

(Received and transferred si_Lens2.dv by FTP)

@sbesson sbesson added the enhancement New feature or request label Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants