-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable pipeline of duplicate output to, e.g., chgrp #18
base: master
Are you sure you want to change the base?
Conversation
In order to enable duplicate commands can exist in a chain of pipelines, update the output of duplicate runs to follow the "Class:ID" style. Note that if `--report` is passed, the old-style output remains. see: https://forum.image.sc/t/same-image-file-in-multiple-omero-groups/45052/6
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/same-image-file-in-multiple-omero-groups/45052/7 |
I copied .pre-commit-config.yaml from omero-rois. The failure I assume is coming from omero-test-infra's use of flake. I assume that means we need to get ome/omero-test-infra#57 merged? |
I thought that this had failed due to a change in object IDs (based on test order or similar), but it's passing locally. I'm re-launching the GHA. |
Re-opening with omero-test-infra update. |
Back to the object IDs issue now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some unclear reasons, this PR was previously excluded from the nightly builds e.g. in https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-plugins-push/1337/consoleText
Repository: ome/omero-cli-duplicate
Excluded PRs:
- PR 18 joshmoore 'Enable pipeline of duplicate output to, e.g., chgrp' (status: failure)
Already up-to-date.
but was reincluded in the last 2 builds e.g. https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-plugins-push/1338/consoleText
Repository: ome/omero-cli-duplicate
Already up-to-date.
Merged PRs:
- PR 18 joshmoore 'Enable pipeline of duplicate output to, e.g., chgrp'
As per the change of the stdout/stderr, this is failing the duplicate CLI tests - see https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/1289/testReport/
👍 Thanks, @sbesson. So the real question is why it got included without being green, no? |
Excluding for now |
In order to enable duplicate commands can exist in
a chain of pipelines, update the output of duplicate
runs to follow the "Class:ID" style.
Note that if
--report
is passed, the old-styleoutput remains.
see: https://forum.image.sc/t/same-image-file-in-multiple-omero-groups/45052/6