Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pipeline of duplicate output to, e.g., chgrp #18

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

joshmoore
Copy link
Member

In order to enable duplicate commands can exist in
a chain of pipelines, update the output of duplicate
runs to follow the "Class:ID" style.

Note that if --report is passed, the old-style
output remains.

see: https://forum.image.sc/t/same-image-file-in-multiple-omero-groups/45052/6

In order to enable duplicate commands can exist in
a chain of pipelines, update the output of duplicate
runs to follow the "Class:ID" style.

Note that if `--report` is passed, the old-style
output remains.

see: https://forum.image.sc/t/same-image-file-in-multiple-omero-groups/45052/6
@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/same-image-file-in-multiple-omero-groups/45052/7

@joshmoore
Copy link
Member Author

I copied .pre-commit-config.yaml from omero-rois. The failure I assume is coming from omero-test-infra's use of flake. I assume that means we need to get ome/omero-test-infra#57 merged?

cc: @sbesson @manics

@joshmoore
Copy link
Member Author

I thought that this had failed due to a change in object IDs (based on test order or similar), but it's passing locally. I'm re-launching the GHA.

@joshmoore
Copy link
Member Author

Re-opening with omero-test-infra update.

@joshmoore joshmoore closed this Dec 6, 2020
@joshmoore joshmoore reopened this Dec 6, 2020
@joshmoore
Copy link
Member Author

Back to the object IDs issue now.

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some unclear reasons, this PR was previously excluded from the nightly builds e.g. in https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-plugins-push/1337/consoleText

Repository: ome/omero-cli-duplicate
Excluded PRs:
  - PR 18 joshmoore 'Enable pipeline of duplicate output to, e.g., chgrp' (status: failure)
Already up-to-date.

but was reincluded in the last 2 builds e.g. https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-plugins-push/1338/consoleText

Repository: ome/omero-cli-duplicate
Already up-to-date.

Merged PRs:
  - PR 18 joshmoore 'Enable pipeline of duplicate output to, e.g., chgrp'

As per the change of the stdout/stderr, this is failing the duplicate CLI tests - see https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/1289/testReport/

@joshmoore
Copy link
Member Author

joshmoore commented Nov 22, 2022

👍 Thanks, @sbesson. So the real question is why it got included without being green, no?

@jburel
Copy link
Member

jburel commented Nov 22, 2022

Excluding for now
--exclude

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants