Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter studies by group #75

Merged
merged 3 commits into from
Feb 26, 2021
Merged

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Dec 21, 2020

See #28 (comment) and https://forum.image.sc/t/customization-of-omero-gallery/46336/7

This allows filtering of Studies in the 'Categories' UI by Group name.

To test:

  • Add "Group" to the filter keys:
    -$ omero config append omero.web.gallery.filter_keys '"Group"' (NB: merge-ci currently configured with ["Name", "Group"]).
  • Choose to filter by group on the home page. This should populate the auto-complete with group names:
  • Pick an auto-complete option (group name) to take you to the 'search' page where the Studies should be filtered by Group:

Screenshot 2020-12-21 at 12 21 48

cc @abhamacher

@abhamacher
Copy link

Tested the changes and settings in our environment too. Works like a charm!

package.json Outdated
@@ -27,7 +27,7 @@
"images"
],
"author": "OME",
"license": "MIT",
"license": "GPLv3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change of license needs to be mentioned
Mistake in first place?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the license AGPL-3.0 ? In general 👍 for fixing the inconsistency and prevent confusion

@pwalczysko
Copy link
Member

Tested on merge-ci. Works as expected.

Probably a different-PR topic
I was wondering about how hard-coded is the word "studies" in the OMERO.gallery ? Is that configurable ?

@will-moore
Copy link
Member Author

@pwalczysko the "studies" naming isn't configurable, no. You could create an issue if it's something that would be useful?

@jburel
Copy link
Member

jburel commented Feb 26, 2021

#78 for comment above

@jburel jburel merged commit 2a17085 into ome:master Feb 26, 2021
@jburel jburel mentioned this pull request Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants